[ https://issues.apache.org/jira/browse/HIVE-20137?focusedWorklogId=493464&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-493464 ]

ASF GitHub Bot logged work on HIVE-20137:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Oct/20 12:29
            Start Date: 01/Oct/20 12:29
    Worklog Time Spent: 10m 
      Work Description: pvargacl commented on a change in pull request #1532:
URL: https://github.com/apache/hive/pull/1532#discussion_r498204987



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -114,16 +114,16 @@
 public class AcidUtils {
   // This key will be put in the conf file when planning an acid operation
   public static final String CONF_ACID_KEY = "hive.doing.acid";
-  public static final String BASE_PREFIX = "base_";
+  public static final String BASE_PREFIX = AcidConstants.BASE_PREFIX;

Review comment:
       I am not sure I want to remove these public constants, the AcidUtils is unfortunately is being used by spark-acid and it might break compatibility...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 493464)
    Time Spent: 40m  (was: 0.5h)

> Truncate for Transactional tables should use base_x
> ---------------------------------------------------
>
>                 Key: HIVE-20137
>                 URL: https://issues.apache.org/jira/browse/HIVE-20137
>             Project: Hive
>          Issue Type: Improvement
>          Components: Transactions
>    Affects Versions: 3.0.0
>            Reporter: Eugene Koifman
>            Assignee: Peter Varga
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> This is a follow up to HIVE-19387.
> Once we have a lock that blocks writers but not readers (HIVE-19369), it would make sense to make truncate create a new base_x, where is x is a writeId in current txn - the same as Insert Overwrite does.
> This would mean it can work w/o interfering with existing writers.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)