httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doug MacEachern <>
Subject Re: new helper module Apache::TestUtil
Date Wed, 05 Sep 2001 17:28:04 GMT
On Sun, 2 Sep 2001, Stas Bekman wrote:

> Here is a new Apache::TestUtil that makes:
> - the writing tests that mess with files and dirs much easier.
> - it automatically takes care of cleanup for all files and dirs created.
> - makes it simpler to write debugable tests: ok $expected eq $received.
> After the patch I've attached a new vhost_alias.t that uses it, so you can
> see how it's used and how shorter it makes the test. If it's all fine,
> I'll commit the changes.

cool, +1.
could you change del_tree to use File::Path::rmtree instead?

and please fix style:
> +sub t_cmp_str{
> +    my ($expect,$received,$comment) = @_;
  +sub t_cmp_str {
  +    my($expect, $received, $comment) = @_;

also, i don't think there is a need for both t_cmp_str and t_cmp_num,
a t_cmp that uses 'eq' should work fine for both numbers and strings, no?

View raw message