httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <>
Subject Re: apxs calls on Win32
Date Wed, 08 Dec 2004 05:36:11 GMT
Randy Kobes wrote:
> On Tue, 7 Dec 2004, Stas Bekman wrote:
>>As soon as you see dup like this, think refactoring :) e.g. add
>>untaint_path(), that does the work and call it:
>>   local $ENV{PATH}) = untaint_path($ENV{PATH});
>>Otherwise +1.
>>And of course this wrapper should probably used in open_cmd too!
> Here's a patch that does that:

Looks good. Randy++

> ==============================================================
> I tried committing it, but was denied access (I ensured I
> did a co with https); perhaps some permissions need
> adjusting (I did have commit access under cvs).

I've requested to restore it (you indeed don't have it). Let me know if 
you want me to commit this or wait for when you get the access again 
(should hopefully be restored tomorrow).

Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker     mod_perl Guide --->

View raw message