httpd-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fred Tyler" <fred...@gmail.com>
Subject [users@httpd] Getting rid of "Vary" -- Follow-up
Date Fri, 04 May 2007 04:09:48 GMT
Well, it turns out that getting rid of Vary within mod_negotiation
isn't as straightforward as I'd hoped, so I've gone and change
http_protocol.c in version 1.3.37 and http_filters.c in 2.2.4 so that
setting "force-no-vary" does not fall back to HTTP/1.0.

The only way I plan to use "force-no-vary" is by putting the following
line in httpd.conf:

BrowserMatch MSIE force-no-vary

With that in mind, can someone who know more about these things than I
do comment on the safety of this approach? As long as I limit
"force-no-vary" to MSIE, is there any risk of *not* degrading to
HTTP/1.0? And are the changes I made in these files sane?

*****************
  Diff for 1.3.37
*****************

--- http_protocol.c,orig        2007-05-04 03:24:18.000000000 +0000
+++ http_protocol.c     2007-05-04 03:49:25.000000000 +0000
@@ -1942,8 +1942,6 @@
      */
     if (ap_table_get(r->subprocess_env, "force-no-vary") != NULL) {
        ap_table_unset(r->headers_out, "Vary");
-       r->proto_num = HTTP_VERSION(1,0);
-       ap_table_set(r->subprocess_env, "force-response-1.0", "1");
     }
     else {
        fixup_vary(r);

*****************
  Diff for 2.2.4
*****************

--- http_filters.c,orig 2007-05-04 04:00:30.000000000 +0000
+++ http_filters.c      2007-05-04 04:02:05.000000000 +0000
@@ -961,8 +961,6 @@
      */
     if (apr_table_get(r->subprocess_env, "force-no-vary") != NULL) {
         apr_table_unset(r->headers_out, "Vary");
-        r->proto_num = HTTP_VERSION(1,0);
-        apr_table_set(r->subprocess_env, "force-response-1.0", "1");
     }
     else {
         fixup_vary(r);

---------------------------------------------------------------------
The official User-To-User support forum of the Apache HTTP Server Project.
See <URL:http://httpd.apache.org/userslist.html> for more info.
To unsubscribe, e-mail: users-unsubscribe@httpd.apache.org
   "   from the digest: users-digest-unsubscribe@httpd.apache.org
For additional commands, e-mail: users-help@httpd.apache.org


Mime
View raw message