ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vladimir Ozerov <voze...@gridgain.com>
Subject Re: classnames.properties file is out of date
Date Mon, 10 Aug 2015 09:36:17 GMT
I agree with you that current approach is prone to errors. But removing "
classnames.properties" is not a good idea I think.
Are you sure that developers will be able to run tests from IDE without any
additional steps? I would rather leave this file as is, but add a new step
during release build which will update this file.

On Mon, Aug 10, 2015 at 12:19 PM, Denis Magda <dmagda@gridgain.com> wrote:

> Vladimir,
>
> Yeah, I did use ClassesGenerator on my local machine to get an up-to-date
> version of the file.
>
> According to GIT history the contributors manually update
> classnames.properties not even leveraging ClassesGenerator.
> In any case all these manual updates are error-prone behavior.
>
> Let's start doing this automatically.
> I would delete classnames.properties from the repository and generate it
> automatically during ignite-core build time.
>
> Any thoughts, objections?
>
> --
> Denis
>
>
> On 8/10/2015 11:55 AM, Vladimir Ozerov wrote:
>
>> Denis,
>>
>> It seems that org.apache.ignite.tools.classgen.ClassesGenerator is what
>> you
>> need.
>>
>> On Mon, Aug 10, 2015 at 11:36 AM, Denis Magda <dmagda@gridgain.com>
>> wrote:
>>
>> Igniters,
>>>
>>> As a part of ignite-core module we have 'classnames.properties' file
>>> located in ignite-core/META-INF folder. The file is internally used by
>>> Ignite marshallers.
>>>
>>> I noted that the version of the file stored in the sources and used by us
>>> in development is out of date (current version from the repository has
>>> bunch of differences in compare to the freshest one).
>>> This file is not updated automatically during the build. It's only
>>> generated automatically generated during package creation.
>>>
>>> Seems that this file is periodically recreated by someone and updated
>>> manually in the sources.
>>>
>>> Who knows anything about the update process for this file? Should I
>>> update
>>> it manually with the newest version?
>>>
>>> --
>>> Denis
>>>
>>>
>>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message