ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrey Gura <ag...@gridgain.com>
Subject Re: Differences in default marshaller
Date Mon, 11 Jan 2016 15:44:01 GMT
Cos,

the problem is that default config
(incubator-zeppelin/ignite/src/main/resources/default-ignite-jdbc.xml)
contains `marshaller` bean definition of OptimizedMarshaller type.
IgniteSqlInterpreter class uses this config.
Just remove this bean definition and default marshaller will be used.

On Mon, Jan 11, 2016 at 11:57 AM, Yakov Zhdanov <yzhdanov@apache.org> wrote:

> Andrey Gura, can you please clarify?
>
> --Yakov
>
> 2016-01-06 22:06 GMT+03:00 Konstantin Boudnik <cos@apache.org>:
>
> > On Tue, Jan 05, 2016 at 10:40PM, Dmitriy Setrakyan wrote:
> > > On Tue, Jan 5, 2016 at 8:12 PM, Konstantin Boudnik <cos@apache.org>
> > wrote:
> > >
> > > > Test is pretty simple and doesn't do anything crazy at least in my
> > > > uneducated
> > > > opinion.
> > > >
> > > > To Yakov's point about using default binary marshaller: it is unclear
> > why
> > > > the
> > > > client node won't use the default then. The test was working with 1.4
> > and
> > > > then
> > > > stopped. It hasn't been touched for a while, which tells me that
> > something
> > > > got
> > > > changed in the underlying library.
> > > >
> > >
> > > Cos, I think you are right. Most likely the client code in Zeppelin
> sets
> > up
> > > the marshaller. We need to update it to work with 1.5. We should also
> > > should allow to specify a default cache per notebook, so users could
> > > override the default cache setting in the interpreter.
> >
> > Looking at the IgniteInterpreter code, again just briefly, there's no way
> > to
> > set the marshaller from the test. But I let ppl more familiar with the
> > matter
> > to chime in. For now the test is fixed, although clumsily.
> >
> > > > Thanks for looking into this!
> > > >   cos
> > > >
> > > > On Tue, Jan 05, 2016 at 01:46PM, Alexey Goncharuk wrote:
> > > > > Server/client mode does not (and should not) change the marshaller
> > > > > settings, to my knowledge there are no such places in the code that
> > might
> > > > > change this behavior.
> > > > >
> > > > > There might be something in the Zep integration test, but I need
> some
> > > > time
> > > > > to install Zep and take a look at the code.
> > > >
> >
>



-- 
Andrey Gura
GridGain Systems, Inc.
www.gridgain.com

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message