ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Muzafarov <maxmu...@gmail.com>
Subject Re: Stop nodes after test by default - IGNITE-6842
Date Tue, 06 Feb 2018 22:10:20 GMT
Hello,

I've made some research about this problem and i think that in general we
should move stopAllGrids method in GridAbstractTest class to
afterTestsStopped method with some changes. Am I right?

Also, I have a question about stopAllGrids(boolean cancel) this "cancel"
argument. Why in some cases we should interrupt ComputeJob and in some
cases shouldn't? For example here:
IgniteBaselineAffinityTopologyActivationTest#afterTest
we call method stopAllGrids(false) this way. Why not "true" argument
instead?



чт, 1 февр. 2018 г. в 16:12, Dmitry Pavlov <dpavlov.spb@gmail.com>:

> Hi Maxim,
>
> I would be happy if this issue is completed.
>
> I think best solultion is
> 1) to validate remained up and running nodes
> 2) and fail test if not-stopped nodes remained
>
> instead of silently stop node. If nodes will be stopped silently, probable
> errors may be missed both in test and in Ignite code.
>
> Sincerely,
> Dmitriy Pavlov
>
> чт, 1 февр. 2018 г. в 3:54, Denis Magda <dmagda@apache.org>:
>
> > Hello Maxim,
> >
> > Granted you all the required permissions in JIRA. Feel free to assign the
> > ticket to your account.
> >
> > In general, review how the testing framework works in Ignite and you’ll
> > get why we stop all the nodes manually. It will help to get answers on
> most
> > of the questions. Please propose your solution or ask for advice here
> after
> > that.
> >
> > —
> > Denis
> >
> > > On Jan 31, 2018, at 8:01 AM, Maxim Muzafarov <maxmuzaf@gmail.com>
> wrote:
> > >
> > > Hello everyone!
> > >
> > > I would like to take this one issue for implicating myself into Ignite
> > > community.
> > >
> > > https://issues.apache.org/jira/browse/IGNITE-6842
> > >
> > > Can you help me with granting contributor permissons?
> > > My JIRA ID: mmuzaf
> > > e-mail: maxmuzaf@gmail.com
> > > So I can assign this ticket for myself, If you don't mind of course.
> > >
> > > Also, it will be great to have something like general roadmap for
> fixing
> > > this issue. What should I look at on my first step?
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message