ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexey Popov <tank2.a...@gmail.com>
Subject Re: IgniteConfiguration, TcpDiscoverySpi, TcpCommunicationSpi timeouts
Date Tue, 06 Mar 2018 12:23:02 GMT
Yakov,

1. The proposal list of parameters to deprecate:
TcpDiscoverySpi.setConnectTimeout (covered by
IgniteConfiguration.setFailureDetectionTimeout)
TcpDiscoverySpi.setReconnectCount (covered by
IgniteConfiguration.setFailureDetectionTimeout)
TcpDiscoverySpi.setSocketTimeout (covered by
IgniteConfiguration.setFailureDetectionTimeout)
TcpDiscoverySpi.setAckTimeout (covered by
IgniteConfiguration.setFailureDetectionTimeout)
TcpDiscoverySpi.setMaxAckTimeout (covered by
IgniteConfiguration.setFailureDetectionTimeout)
TcpDiscoverySpi.setNetworkTimeout (IgniteConfiguration.setNetworkTimeout
should be used here)
TcpCommunicationSpi.setConnectTimeout (covered by
IgniteConfiguration.setFailureDetectionTimeout)
TcpCommunicationSpi.setMaxConnectTimeout (covered by
IgniteConfiguration.setFailureDetectionTimeout)
TcpCommunicationSpi.setReconnectCount (covered by
IgniteConfiguration.setFailureDetectionTimeout)
TcpCommunicationSpi.setSocketWriteTimeout
(IgniteConfiguration.setNetworkTimeout should be used here)

2. Internal logic should continue to use
IgniteConfiguration.setFailureDetectionTimeout and
IgniteConfiguration.setNetworkTimeout as it is now.
The deprecated parameters should be alive for a while with the corresponding
javadoc update.
TcpDiscoverySpi.getNetworkTimeout should use
IgniteConfiguration.getNetworkTimeout by default.
TcpCommunicationSpi.getSocketWriteTimeout should use
IgniteConfiguration.getNetworkTimeout by default.

In a few releases, the deprecated parameters could be removed.

3. I think we can keep the existent description of the parameters. Probably,
it could be updated for more clear statements for
IgniteConfiguration.setFailureDetectionTimeout and
IgniteConfiguration.setNetworkTimeout.

Thanks,
Alexey



--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

Mime
View raw message