ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitry Pavlov <dpavlov....@gmail.com>
Subject Re: [TeamCity] DataFrame Examples
Date Mon, 19 Mar 2018 13:08:40 GMT
Hi Igniters,

 It seems to me it is better to keep one suite. It is reasonable to
separate suites if tests requires too much time to run.

Using the same suite will save remarkable amount of agent time.

Sincerely,
Dmitriy Pavlov

вс, 18 мар. 2018 г. в 19:34, Nikolay Izhikov <nizhikov@apache.org>:

> Hello, guys.
>
> I think we are ready to enable testing of Spark examples on Team City.
> Can you help me with best choice to do it?
>
> Currently, we have 'Ignite Examples' to run `IgniteExamplesSelfTestSuite`.
>
> We also have a `IgniteExamplesSparkSelfTestSuite` to test spark example.
> `IgniteExamplesSparkSelfTestSuite` exists in source only if `spark`
> profile enabled so we can't just add it to `IgniteExamplesSelfTestSuite`.
>
> I see following option here:
>
> 1. Edit 'Ignite Examples' to run both `IgniteExamplesSelfTestSuite` and
> `IgniteExamplesSparkSelfTestSuite`.
> 2. Create new test plan to run `IgniteExamplesSparkSelfTestSuite`.
>
> Thoughts?
>
> P.S. We also need minor changes [1] to make sure Spark examples are
> running correctly.
>
> [1] https://github.com/apache/ignite/pull/3590
>
> В Вт, 27/02/2018 в 11:56 -0800, Valentin Kulichenko пишет:
> > If we can run Scala examples there, then yes.
> >
> > -Val
> >
> > On Tue, Feb 27, 2018 at 11:54 AM, Dmitry Pavlov <dpavlov.spb@gmail.com>
> > wrote:
> >
> > > Nikolay, Val,
> > >
> > > Could these examples be tested in standard Ignite Examples test suite?
> As
> > > far as I know Ignite ML and Ignite IGFS are also tested there.
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > вт, 27 февр. 2018 г. в 22:49, Valentin Kulichenko <
> > > valentin.kulichenko@gmail.com>:
> > >
> > > > Nikolay,
> > > >
> > > > Spark integration is not related to Scalar, the only thing they have
> in
> > > > common is Scala. I think we should have a separate configuration for
> > > > ignite-spark module. If anything Spark related is currently in Scalar
> > > > suite, it should be moved from there.
> > > >
> > > > -Val
> > > >
> > > > On Tue, Feb 27, 2018 at 3:03 AM, Nikolay Izhikov <
> nizhikov@apache.org>
> > > > wrote:
> > > >
> > > > > Hello, Igniters.
> > > > >
> > > > > I've created several examples for a Ignite DataFrame.
> > > > > Currently, they are not tested on Team City.
> > > > >
> > > > > As far as I can understand, they should be checked in "Ignite
> Scalar
> > > > > Examples [Scala]".
> > > > > But it marked as obsolete [1]
> > > > >
> > > > > Please, give me advice:
> > > > >
> > > > > 1. Should we test Ignite DataFrame examples on Team City?
> > > > >
> > > > > 2. Which plan should be used for that?
> > > > >
> > > > > [1]
> > > >
> > > >
> https://ci.ignite.apache.org/viewLog.html?buildId=1068099&buildTypeId=
> > > > > IgniteTestsForCodeCoverage_IgniteScalarExamples&tab=buildParameters

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message