ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitriy Setrakyan <dsetrak...@apache.org>
Subject Re: Pushing forward IGNITE-6826: Change default DiscoverySpi ipFinder type for examples
Date Thu, 19 Jul 2018 02:29:48 GMT
I am confused, the TcpDiscoveryVmIpFinder will only discover nodes with
specified list of IPs. Don't we have examples that require remote nodes to
join?

D.

On Wed, Jul 18, 2018 at 7:52 AM, Stanislav Lukyanov <stanlukyanov@gmail.com>
wrote:

> > It can seem not important, but saves a minute for everyone.
> No, it actually does seem important when you think about it :) Thanks for
> the suggestion.
> Let me correct this then.
>
> The issue is
> IGNITE-6826: Change default DiscoverySpi ipFinder type for examples
> https://issues.apache.org/jira/browse/IGNITE-6826
> It is about changing the ipFinders used in the Ignite examples from
> TcpDiscoveryMulticastIpFinder to TcpDiscoveryVmIpFinder.
>
> Thanks,
> Stan
>
> From: Dmitry Pavlov
> Sent: 18 июля 2018 г. 17:30
> To: dev@ignite.apache.org
> Cc: antkr.dev@gmail.com; SomeFireOne@gmail.com; ptupitsyn@apache.org
> Subject: Re: Pushing IGNITE-6826 forward
>
> Hi Stanislav,
>
> I wish this push will have effect.
>
> Just two proposals that will help Igniters to easily jump into such emails:
> 1. Include ticket short description into subject, not only number.
> 2. Include link to JIRA issue into body so it could be easily clicked to
> find out details.
> It can seem not important, but saves a minute for everyone.
>
> Sincerely,
> Dmitriy Pavlov
>
> ср, 18 июл. 2018 г. в 16:32, Stanislav Lukyanov <stanlukyanov@gmail.com>:
>
> > Hi Igniters,
> >
> > There is a small but annoying issue with examples using MulticastIpFinder
> > by default.
> > The JIRA is  IGNITE-6826.
> >
> > AntonK and DmitriiR have suggested PRs to fix this, but PavelT had some
> > concerns and the fix stuck as the result.
> >
> > Pavel, could you please suggest necessary changes to the PRs so that guys
> > can move forward with integration?
> >
> > Thanks,
> > Stan
> >
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message