ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitriy Pavlov <dpavlov....@gmail.com>
Subject Re: IP finder in tests
Date Wed, 01 Aug 2018 17:39:50 GMT
Hi Dmitriy,

I guess this ticket relates to examples, but new proposal is related only
to test.

Community didn't make an agreement about examples change, so I suggest to
create new ticket (and probably link both tickets) and PR.

Sincerely,
Dmitriy Pavlov

ср, 1 авг. 2018 г. в 20:30, Dmitrii Ryabov <somefireone@gmail.com>:

> We have ticket [1] for this change.
>
> [1] https://issues.apache.org/jira/browse/IGNITE-6826
>
> 2018-08-01 15:58 GMT+03:00 Alexey Zinoviev <zaleslaw.sin@gmail.com>:
>
> > Great, sometimes I made it manually in local tests. It will be great to
> > change the situation.
> >
> > 2018-08-01 18:22 GMT+06:00 Stanislav Lukyanov <stanlukyanov@gmail.com>:
> >
> > > +1.
> > >
> > > I don’t see why do we need to fallback to multicast for multi-JVM –
> let’s
> > > just set 127.0.0.1:47500..47509 by default,
> > > it’ll be enough for most (if not all) tests.
> > >
> > > Stan
> > >
> > > From: Dmitriy Pavlov
> > > Sent: 1 августа 2018 г. 14:21
> > > To: dev@ignite.apache.org
> > > Subject: Re: IP finder in tests
> > >
> > > Hi Denis,
> > >
> > > Thank you for bringing the question here.
> > >
> > > I totally support this change.
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > ср, 1 авг. 2018 г. в 13:23, Denis Mekhanikov <dmekhanikov@gmail.com>:
> > >
> > > > Igniters,
> > > >
> > > > Almost every test in Ignite project has the following pattern: shared
> > > > *TcpDiscoveryVmIpFinder
> > > > *is defined as a field of a test class, which is then used in
> discovery
> > > > configuration in *getConfiguration(...)* method. There are more than
> > 700
> > > > test classes with this setup.
> > > >
> > > > But for some reason *TcpDiscoveryMulticastIpFinder *is used in tests
> by
> > > > default. I don't think, that it should be used in tests at all, since
> > > > external nodes may accidentally affect test results.
> > > >
> > > > The only case, where it makes sense is multi JVM tests. Shared static
> > IP
> > > > finder is not applicable there, since nodes are run in different JVMs
> > and
> > > > cannot share the same IP finder object.
> > > >
> > > > I would like to change the default IP finder to a shared
> > > > *TcpDiscoveryVmIpFinder.
> > > > *In cases, when *GridAbstractTest#isMultiJvm() *returns *true*, we
> > could
> > > > fall back to multicast.
> > > >
> > > > What do you think?
> > > >
> > > > Denis
> > > >
> > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message