ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] SomeFire commented on a change in pull request #87: IGNITE-10540 "Compare builds" page with Internal Server Error [500]
Date Wed, 05 Dec 2018 10:57:08 GMT
SomeFire commented on a change in pull request #87: IGNITE-10540 "Compare builds" page with
Internal Server Error [500]
URL: https://github.com/apache/ignite-teamcity-bot/pull/87#discussion_r239018971
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/builds/CompareBuildsService.java
 ##########
 @@ -40,12 +40,17 @@
     private static final Logger logger = LoggerFactory.getLogger(CompareBuildsService.class);
 
     @Inject ITcServerProvider helper;
-    @Inject ICredentialsProv prov;
     @Inject BuildChainProcessor bcp;
     @Inject ITeamcityIgnitedProvider tcIgnitedProv;
     @Inject IStringCompactor compactor;
 
-    public List<String> tests0(String srvId, Integer buildId ) {
+    /**
+     * @param srvId Server id.
+     * @param buildId Build id.
+     * @param prov Credentials provider
 
 Review comment:
   ```suggestion
        * @param prov Credentials provider.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message