ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] asfgit closed pull request #87: IGNITE-10540 "Compare builds" page with Internal Server Error [500]
Date Wed, 05 Dec 2018 12:39:21 GMT
asfgit closed pull request #87: IGNITE-10540 "Compare builds" page with Internal Server Error
URL: https://github.com/apache/ignite-teamcity-bot/pull/87

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/builds/CompareBuildsService.java
index e420ca45..8ca0b24f 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/builds/CompareBuildsService.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/builds/CompareBuildsService.java
@@ -40,12 +40,17 @@
     private static final Logger logger = LoggerFactory.getLogger(CompareBuildsService.class);
     @Inject ITcServerProvider helper;
-    @Inject ICredentialsProv prov;
     @Inject BuildChainProcessor bcp;
     @Inject ITeamcityIgnitedProvider tcIgnitedProv;
     @Inject IStringCompactor compactor;
-    public List<String> tests0(String srvId, Integer buildId ) {
+    /**
+     * @param srvId Server id.
+     * @param buildId Build id.
+     * @param prov Credentials provider.
+     * @return List of build tests.
+     */
+    public List<String> tests0(String srvId, Integer buildId, ICredentialsProv prov
) {
         IAnalyticsEnabledTeamcity teamcity = helper.server(srvId, prov);
         String hrefById = teamcity.getBuildHrefById(buildId);
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/build/CompareBuilds.java
index e46ce5a9..87db6cfa 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/build/CompareBuilds.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/build/CompareBuilds.java
@@ -123,6 +123,6 @@ public String getTestFailsComparision(
         if (!prov.hasAccess(srv))
             throw ServiceUnauthorizedException.noCreds(srv);
-        return compareBuildsSvc.tests0(srv, buildId);
+        return compareBuildsSvc.tests0(srv, buildId, prov);


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message