ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] dspavlov commented on a change in pull request #94: Visa History page fix
Date Fri, 07 Dec 2018 18:18:14 GMT
dspavlov commented on a change in pull request #94: Visa History page fix
URL: https://github.com/apache/ignite-teamcity-bot/pull/94#discussion_r239899293
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/teamcity/ignited/ITeamcityIgnited.java
 ##########
 @@ -167,4 +167,9 @@ public default FatBuildCompacted getFatBuild(int id) {
      * @return run statistics of recent runls on all branches.
      */
     @Nullable public IRunStat getSuiteRunStatAllBranches(String suiteBuildTypeId);
+
 
 Review comment:
   this change will create 2 responsibility for TC Ignited: it will be as always interface
to persisted data, but also it will be a provider of the compactor. Is it better to keep it
separated and provide compactor as a parameter or using context?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message