ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vyacheslav Daradur <daradu...@gmail.com>
Subject Set 'TcpDiscoveryVmIpFinder' as default IP finder for tests instead of 'TcpDiscoveryMulticastIpFinder'
Date Wed, 05 Dec 2018 13:51:38 GMT

I've found that the project's test framework uses
'TcpDiscoveryMulticastIpFinder' as default IP finder for tests and
there are a lot of tests written by Ignite's experts that override it
to 'TcpDiscoveryVmIpFinder'.

Most of our tests starting Ignite nodes in the same JVM, that allows
us using shared 'TcpDiscoveryVmIpFinder'.

I think that using of 'TcpDiscoveryMulticastIpFinder' may be useful
only in platforms tests, BTW multi-JVM tests use the tuned

I see the following main advantages of using 'TcpDiscoveryVmIpFinder':
* reducing possible conflicts in the development environment, when
nodes from different clusters may find each other;
* speedup of nodes initial discovery, especially on Windows;
* avoiding of overwriting 'getConfiguration' and copypasta only to set
up static IP finder in tests;

So, I'd suggest changing the default IP finder in tests to
'TcpDiscoveryVmIpFinder' as the first step and remove related
boilerplate as the second step.

What do you think?

Best Regards, Vyacheslav D.

View raw message