ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitriy Pavlov <dpav...@apache.org>
Subject Re: Is it time to move forward to JUnit4 (5)?
Date Mon, 10 Dec 2018 17:52:20 GMT
Vladimir, AFAIK there will be no single change for overall migration. All
migration will be in a step-by-step manner and mostly transparent for
contributors.

Both approaches 3&4 will be available for some time.

First of all, we need an opportunity to run existing integration tests in
JUnit4.

пн, 10 дек. 2018 г. в 20:38, Vladimir Ozerov <vozerov@gridgain.com>:

> Ed,
>
> Several questions from my side:
> 1) When the change is expected to be merged?
> 2) What contributors with opened PRs and new or updated JUnit3 tests are
> supposed to do? Rewrite to JUnit4?
>
> If yes, then we should give them time to have a chance to get used to new
> approach and resolve possible conflicts.
>
> Vladimir.
>
> пн, 10 дек. 2018 г. в 20:32, Eduard Shangareev <
> eduard.shangareev@gmail.com
> >:
>
> > Ivan,
> >
> > So, suggested actions with the new approach:
> > 1. Add @Test annotation on test methods.
> > 2. Add @RunWith(JUnit4.class) annotation on test class.
> > 3. Add @Before, @After on methods which should run before, after a
> > test (setUp, tearDown in current approach).
> > 4. Add your test-class to a suite using suite.addTest(new
> > JUnit4TestAdapter(YourTestClass.class));
> > 5. Use @Ignore instead fail(); for muting test.
> > 6. You could start using @Parametrized instead of inheritance.
> >
> >
> > On Mon, Dec 3, 2018 at 1:15 PM Павлухин Иван <vololo100@gmail.com>
> wrote:
> >
> > > Hi Oleg,
> > >
> > > I noticed that GridAbstractTest is now capable to run junit4 tests.
> > > What are the current recommendations for writing new tests? Can we use
> > > junit4 annotation for new tests?
> > > пн, 12 нояб. 2018 г. в 19:58, oignatenko <oignatenko@gridgain.com>:
> > > >
> > > > Hi Ivan,
> > > >
> > > > I am currently testing approach you used in pull/5354 in the "pilot"
> > > > sub-task with examples tests (IGNITE-10174).
> > > >
> > > > So far it looks more and more like the way to go. The most promising
> > > thing I
> > > > observed is that after I changed classes in our test framework the
> way
> > > you
> > > > did, execution of (unchanged) examples tests went exactly the same as
> > it
> > > was
> > > > before changes.
> > > >
> > > > This indicates that existing tests won't be affected making it indeed
> > low
> > > > risk.
> > > >
> > > > After that I converted examples tests to Junit 4 by adding @RunWith
> and
> > > > @Test annotations and tried a few, and these looked okay.
> > > >
> > > > Currently I am running full examples test suite and after it is over
> I
> > > will
> > > > compare results to the reference list I made by running it prior to
> > > > migration.
> > > >
> > > > regards, Oleg
> > > >
> > > >
> > > >
> > > > --
> > > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> > >
> > >
> > >
> > > --
> > > Best regards,
> > > Ivan Pavlukhin
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message