From dev-return-42786-apmail-ignite-dev-archive=ignite.apache.org@ignite.apache.org Mon Dec 3 10:15:49 2018 Return-Path: X-Original-To: apmail-ignite-dev-archive@minotaur.apache.org Delivered-To: apmail-ignite-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A9AB518FBA for ; Mon, 3 Dec 2018 10:15:49 +0000 (UTC) Received: (qmail 22370 invoked by uid 500); 3 Dec 2018 10:15:49 -0000 Delivered-To: apmail-ignite-dev-archive@ignite.apache.org Received: (qmail 22322 invoked by uid 500); 3 Dec 2018 10:15:49 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 22306 invoked by uid 99); 3 Dec 2018 10:15:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Dec 2018 10:15:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4662318B35F for ; Mon, 3 Dec 2018 10:15:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.446 X-Spam-Level: * X-Spam-Status: No, score=1.446 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FROM_EXCESS_BASE64=0.105, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URI_HEX=1.313] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Yejb8y-igEG4 for ; Mon, 3 Dec 2018 10:15:46 +0000 (UTC) Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id BD6F75FACE for ; Mon, 3 Dec 2018 10:15:45 +0000 (UTC) Received: by mail-ot1-f52.google.com with SMTP id 32so11022241ota.12 for ; Mon, 03 Dec 2018 02:15:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=yifxv1/70FLqdSG//PlcnW4N7ZcnZuNUxBr2KFP7m/o=; b=QMr0rOIxgVvCv35xVC6gVnWUSU9dpTKU8rfvkvV6G0BxFEMxCWg4pxql3RmTNmgI4l Wft2VvFYqfOVNq/UPXX57HBvQ4hmWHb87ZCJlw7FRgMbZ+vm3VL0mfHW6Qvn04WLntBl LnS+EzfcHRXP8oSX6IjizxGbeLpkiA8l2o8UP5aUZ9SM0SL8tMOzhEOT3rJnQh5xx9/4 Ug6ZR+g1CACprbV2qIwD0EunoRQdaOuYJoKNqObOrYmAdJV/bLIvtiqyqcVUIH5+417B TiwaymxQzIKRL+u9e8k+kveHA2r+O86Pq6mhR5vhYRHZS8vmh35HmlrTSL94NpAWETDn L4cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=yifxv1/70FLqdSG//PlcnW4N7ZcnZuNUxBr2KFP7m/o=; b=azqXJwHRE0dCb320tRHS5NJTnrGKw4DutT0b2/jVsRXr07793dNVtVkg5W9xN25gl/ 6/oi2YyECqXBeNQkemAbWExp9R4U0DBYQFZ+jJUUCpzZNqqQUjpZK29CehPvHi+hEqJu mCi/QYD6e6dkfka41cn36ATCQd5fqlEf7V2tif86oP9VLhGGayKQoKun7bW7xSPj6DuH Zd6I64edm7/1oAxNqxq5nDvUag2cdwlveDHoY/skAqwCWcmLM618bwWYB+UJ1oyunG7u TGHeZUCOb0r8k0nx7ogIMfs0x1yGfozYJX/SIBpexMNgIFFA6GyHPYiqoAd/phNP1as7 1r4w== X-Gm-Message-State: AA+aEWaB5aFNqYuwEyXcxYBDtWsNMmHQpC+kVfNkbB9Z7T+WLFGxhtph 9mXHfqsRmCBsB7jJ7HjNA3UMjf5FKmviR44wSbJ4cA== X-Google-Smtp-Source: AFSGD/Ug6bvv1LhxQfYevSc52cVP6b3Rag7QZDul73O/54pXpyccWxG/N24AKufkIpqVXnLnLyplRmluyTFn13UCe1I= X-Received: by 2002:a9d:724d:: with SMTP id a13mr10390871otk.193.1543832144814; Mon, 03 Dec 2018 02:15:44 -0800 (PST) MIME-Version: 1.0 References: <1541609865653-0.post@n4.nabble.com> <1541771333836-0.post@n4.nabble.com> <1542041892907-0.post@n4.nabble.com> In-Reply-To: <1542041892907-0.post@n4.nabble.com> From: =?UTF-8?B?0J/QsNCy0LvRg9GF0LjQvSDQmNCy0LDQvQ==?= Date: Mon, 3 Dec 2018 13:15:33 +0300 Message-ID: Subject: Re: Is it time to move forward to JUnit4 (5)? To: dev@ignite.apache.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Oleg, I noticed that GridAbstractTest is now capable to run junit4 tests. What are the current recommendations for writing new tests? Can we use junit4 annotation for new tests? =D0=BF=D0=BD, 12 =D0=BD=D0=BE=D1=8F=D0=B1. 2018 =D0=B3. =D0=B2 19:58, oigna= tenko : > > Hi Ivan, > > I am currently testing approach you used in pull/5354 in the "pilot" > sub-task with examples tests (IGNITE-10174). > > So far it looks more and more like the way to go. The most promising thin= g I > observed is that after I changed classes in our test framework the way yo= u > did, execution of (unchanged) examples tests went exactly the same as it = was > before changes. > > This indicates that existing tests won't be affected making it indeed low > risk. > > After that I converted examples tests to Junit 4 by adding @RunWith and > @Test annotations and tried a few, and these looked okay. > > Currently I am running full examples test suite and after it is over I wi= ll > compare results to the reference list I made by running it prior to > migration. > > regards, Oleg > > > > -- > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ --=20 Best regards, Ivan Pavlukhin