ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrey Mashenkov <andrey.mashen...@gmail.com>
Subject Re: Code styles issues in IGNITE-11750
Date Fri, 07 Jun 2019 15:37:03 GMT
Nikolay,

+1.
I'd add my 50 cents.
There should no TODOs without any ticket link, otherwise such TODOs will
never be fixed.

On Fri, Jun 7, 2019 at 4:23 PM Andrey Gura <agura@apache.org> wrote:

> Big +1 from me.
> Make code base clean and clear.
>
> On Fri, Jun 7, 2019 at 3:26 PM Nikolay Izhikov <nizhikov@apache.org>
> wrote:
> >
> > Hello, Igniters.
> >
> > Please, pay attention to commits quality.
> >
> > 1. Please, writer Javadocs.
> > 2. Please, make the new lines according to code style.
> >
> > Issues like [1] has to be fixed *BEFORE* commit.
> >
> >
> > [1]
> https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/SharedPageLockTracker.java#L45
> >
>


-- 
Best regards,
Andrey V. Mashenkov

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message