ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Павлухин Иван <vololo...@gmail.com>
Subject Re: [Code Style Check] TC issues in master
Date Thu, 13 Jun 2019 10:18:24 GMT
Petr, Nikolay,

Running some kind of smoke test might be a good idea. But I think it
should be discussed separately in another thread.

чт, 13 июн. 2019 г. в 11:43, Petr Ivanov <mr.weider@gmail.com>:
>
> I do not know, some basic tests (running single instance of Ignite, activation, simple
cluster topology, etc.)
> It seems that it is more critical than stylecheck, that can be fixed in several lines
of code, but will steal a day (night) of tests.
>
>
> > On 13 Jun 2019, at 11:42, Nikolay Izhikov <nizhikov@apache.org> wrote:
> >
> > Hello, Petr.
> >
> > I think we should be specific here.
> >
> > For me: "code style" fail should be equal to "compilation fail".
> > Can you clarify, what fundamental tests you are written about?
> >
> > В Чт, 13/06/2019 в 11:26 +0300, Petr Ivanov пишет:
> >> How about including basic set of tests (sanity checks) into ~Build Apache Ignite~?
> >> Or may be we can go even further and use cascade system of tests — run them
group by group, stopping the whole run if more fundamental tests are failing?
> >>
> >>
> >>> On 12 Jun 2019, at 21:54, Nikolay Izhikov <nizhikov@apache.org> wrote:
> >>>
> >>> +1 for including checkstyl to "Build Apache Ignite".
> >>>
> >>> В Ср, 12/06/2019 в 21:29 +0300, Павлухин Иван пишет:
> >>>> Maxim,
> >>>>
> >>>> Options 1 and 3 sounds fine to me. And taking into account current
> >>>> state I tend to think that option 1 is even better.
> >>>>
> >>>> вт, 11 июн. 2019 г. в 14:19, Maxim Muzafarov <maxmuzaf@gmail.com>:
> >>>>>
> >>>>> Dmitry,
> >>>>>
> >>>>> Thank you.
> >>>>> Sure, I'll not change anything on TC without discussion with all
the community.
> >>>>>
> >>>>> On Tue, 11 Jun 2019 at 13:30, Dmitriy Pavlov <dpavlov@apache.org>
wrote:
> >>>>>>
> >>>>>> Hi Maxim,
> >>>>>>
> >>>>>> I've granted role Ignite Tests Admins to your account. Please
check.
> >>>>>>
> >>>>>> Please notify community on any significant changes you do. Unfortunately,
> >>>>>> TC parameters audit is not so convenient as VCS-based configuration/code.
> >>>>>>
> >>>>>> Sincerely
> >>>>>> Dmitriy Pavlov
> >>>>>>
> >>>>>> пн, 10 июн. 2019 г. в 17:03, Maxim Muzafarov <maxmuzaf@gmail.com>:
> >>>>>>
> >>>>>>> Igniters,
> >>>>>>>
> >>>>>>> It seems to me that building [ignite-scalar] module under
JDK9+ have
> >>>>>>> been successfully solved for the ~Build Apache Ignite~ suite
[1] [2]
> >>>>>>> [3], but it was not configured for the [Check Code Style]
suite. We
> >>>>>>> should configure it the same way (but it sounds to me very
odd). I
> >>>>>>> see, that we have several options here:
> >>>>>>>
> >>>>>>> 1. Enable `checkstyle` profile for the ~Build Apache Ignite~
suite as
> >>>>>>> we've discussed it previously [4] and forget about any duplicate
> >>>>>>> configuration once and for all. One more thing to do so
is that check
> >>>>>>> style has been violated for a few days and nobody mentioned
it [5].
> >>>>>>>
> >>>>>>> 2. Since the checkstyle plugin is not related to scala-source
code (it
> >>>>>>> does not check it) we can exclude scala modules from maven
build
> >>>>>>> procedure for the checkstyle suite by adding some command-line
> >>>>>>> parameters (test them locally, but have no TC permissions
to check it
> >>>>>>> on TC):
> >>>>>>> -pl
> >>>>>>> -:ignite-scalar_2.10,-:ignite-scalar,-:ignite-visor-console,-:ignite-visor-console_2.10
> >>>>>>>
> >>>>>>> 3. Configure [Check Code Style] the same way as ~Build Apache
Ignite~
> >>>>>>> to support builds for JDK9+.
> >>>>>>>
> >>>>>>> WDYT?
> >>>>>>> What options will be the best for the Apache Ignite?
> >>>>>>>
> >>>>>>> [1] https://github.com/scala/bug/issues/10871
> >>>>>>> [2] https://issues.apache.org/jira/browse/IGNITE-6730
> >>>>>>> [3] https://issues.apache.org/jira/browse/IGNITE-11189
> >>>>>>> [4]
> >>>>>>> http://apache-ignite-developers.2346864.n4.nabble.com/Code-inspection-tp27709p41297.html
> >>>>>>> [5] https://issues.apache.org/jira/browse/IGNITE-11899
> >>>>>>>
> >>>>>>> On Fri, 7 Jun 2019 at 15:36, Nikolay Izhikov <nizhikov@apache.org>
wrote:
> >>>>>>>>
> >>>>>>>> Hello, Petr.
> >>>>>>>>
> >>>>>>>>> at least Scala does not compile
> >>>>>>>>
> >>>>>>>> How cat I reproduce it?
> >>>>>>>> Do we have ticket?
> >>>>>>>>
> >>>>>>>> В Пт, 07/06/2019 в 15:28 +0300, Petr Ivanov пишет:
> >>>>>>>>> Suite fails because Apache Ignite compilation is
not supported under
> >>>>>>>
> >>>>>>> JDK 9+ (at least Scala does not compile).
> >>>>>>>>> Your build from [3] was triggered with JDK 11.
> >>>>>>>>>
> >>>>>>>>>> On 7 Jun 2019, at 14:57, Maxim Muzafarov <maxmuzaf@gmail.com>
wrote:
> >>>>>>>>>>
> >>>>>>>>>> Igniters,
> >>>>>>>>>>
> >>>>>>>>>> I've noticed a few problems with Code Style
Check Suite on TC in the
> >>>>>>>>>> master branch.
> >>>>>>>>>>
> >>>>>>>>>> 1. Some of the rules have been violated by previous
commits to the
> >>>>>>>>>> master branch. I've created ticket [1] and have
prepared PR [2] which
> >>>>>>>>>> is fixing it.
> >>>>>>>>>> Dmitry, or maybe someone else, can you take
a look, please?
> >>>>>>>>>>
> >>>>>>>>>> 2. The Code Style Check Stuite still fails (time
to time) on TC with
> >>>>>>>>>> compile error on [ignite-scalar] module
> >>>>>>>>>> (java.lang.NoClassDefFoundError: javax/tools/ToolProvider).
For
> >>>>>>>>>> instance, this build [3] fails and this is fully
ok [4]. However, the
> >>>>>>>>>> ~Build Apache Ignite~ Suite with almost the
same configuration passes
> >>>>>>>>>> normally.
> >>>>>>>>>>
> >>>>>>>>>> I'd like to create a new suite with checkstyle
for debug purposes,
> >>>>>>>
> >>>>>>> can
> >>>>>>>>>> anyone grant permission to copy\clone\edit suites
on TC? My login:
> >>>>>>>>>> maxmuzaf@gmail.com
> >>>>>>>>>>
> >>>>>>>>>> [1] https://issues.apache.org/jira/browse/IGNITE-11899
> >>>>>>>>>> [2] https://github.com/apache/ignite/pull/6597
> >>>>>>>>>> [3]
> >>>>>>>
> >>>>>>> https://ci.ignite.apache.org/viewLog.html?buildId=4020653&buildTypeId=IgniteTests24Java8_CheckCodeStyle&tab=buildLog&branch_IgniteTests24Java8=%3Cdefault%3E
> >>>>>>>>>> [4]
> >>>>>>>
> >>>>>>> https://ci.ignite.apache.org/viewLog.html?buildId=4021372&buildTypeId=IgniteTests24Java8_CheckCodeStyle
> >>>>>>>>>
> >>>>>>>>>
> >>>>
> >>>>
> >>>>
> >>
> >>
>


-- 
Best regards,
Ivan Pavlukhin

Mime
View raw message