From dev-return-46251-apmail-ignite-dev-archive=ignite.apache.org@ignite.apache.org Wed Jun 12 18:52:11 2019 Return-Path: X-Original-To: apmail-ignite-dev-archive@minotaur.apache.org Delivered-To: apmail-ignite-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 8A60218427 for ; Wed, 12 Jun 2019 18:52:11 +0000 (UTC) Received: (qmail 65965 invoked by uid 500); 12 Jun 2019 18:52:10 -0000 Delivered-To: apmail-ignite-dev-archive@ignite.apache.org Received: (qmail 65927 invoked by uid 500); 12 Jun 2019 18:52:10 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 65909 invoked by uid 99); 12 Jun 2019 18:52:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Jun 2019 18:52:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 0EA0D1A443D for ; Wed, 12 Jun 2019 18:52:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.462 X-Spam-Level: * X-Spam-Status: No, score=1.462 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URI_HEX=1.313] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ZThXTCAsRHCr for ; Wed, 12 Jun 2019 18:51:59 +0000 (UTC) Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 957435FDB8 for ; Wed, 12 Jun 2019 18:51:57 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id h10so10172580ljg.0 for ; Wed, 12 Jun 2019 11:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:message-id:subject:to:date:in-reply-to:references :mime-version; bh=W9mtb93RWbPbAsGtkzIXsAjcfG1UbREzO9xln+UI8RE=; b=iHXRZ/41XVR2ZSHV06bGay84GmidPE1RujH1nBGzuxMbNupjsO3AyUaakJdlnyx6Lg nNz1lPkU85v0vXNl5p6FYjQPy2jyl1g2q25jg93qU/TQNBRwRkvXG2mzxx+7M9KyhB0I UoZYoxLNRIsrWdnK0XsCvDfHyZb0Hv4xhXxFr3BAkY0fwA5qxoXUZyaT2HIZaEco2LqP hKhzAgWhHsN817ey0sh+GC0WSN1zPLHGmsG+UK0BJGGoXaVUG20RdSrXjS9xFoDtM1q7 irnZsYcu0+6Vmw6tc61ZfuEumKHD5HaLc3mX8CLchEh1U7XRJWv1tSzLE516NDuD2ZGR R8QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:message-id:subject:to:date :in-reply-to:references:mime-version; bh=W9mtb93RWbPbAsGtkzIXsAjcfG1UbREzO9xln+UI8RE=; b=ViCsh8suwdLjmkeCxkRQNkYGK5zyLlRS5tKTRxX8ODVcHbvhoNuuUJOPlA2CLGrJyN LoeRlleKSp/prmB0DluR8hLzGLaG0D43uYOwlm3ZcX6lhP5kt3cRekt4tBr7A7um069l R0zdRxYalnzCrpsjPOFJVk90Q7vaFwB8CmZxla3JCdUKJLV/0W6Lf5eEzn1ROrX2e8Xr mS4CFgLDByKhRPv1uQ0paZJIrSTidGCw0GCBMvykmD5Nf463BNmvYko0sS2Vd+vrdnfL mjz6jlnaexUbB+3jerW+xyV3DMwyNfoV0Y8PL9hvXq8DN+jVdDkX1SBfkAMbQLbfvdhy MPfg== X-Gm-Message-State: APjAAAVao+WaNdnWBfsG+uclTey/WyIVe5mKHdV3uNYcysalBKJT8HCG 2Z0lQKxzWsf1hSOTznxArA5TNLWY X-Google-Smtp-Source: APXvYqzDEHyWJzA5W/Kp4vFWhrwglrdCq0cNQ8Nhs4tVO2b36vtbLz6/xCSZovaKTXNJSMY9D1EjCg== X-Received: by 2002:a2e:9592:: with SMTP id w18mr16215548ljh.20.1560365516215; Wed, 12 Jun 2019 11:51:56 -0700 (PDT) Received: from newDragon ([5.35.103.225]) by smtp.googlemail.com with ESMTPSA id a25sm123136lfc.28.2019.06.12.11.51.55 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Jun 2019 11:51:55 -0700 (PDT) Sender: =?UTF-8?B?0J3QuNC60L7Qu9Cw0Lkg0JjQttC40LrQvtCy?= From: Nikolay Izhikov X-Google-Original-From: Nikolay Izhikov Message-ID: Subject: Re: [Code Style Check] TC issues in master To: dev@ignite.apache.org Date: Wed, 12 Jun 2019 21:54:20 +0300 In-Reply-To: References: <64EA1306-8A71-4FA0-9781-3B82CBF8F955@gmail.com> <8376c6462cdd85befdc5b672fd1c6352ddee098f.camel@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-OrfOd0I4LxmEDrqhbqtz" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 --=-OrfOd0I4LxmEDrqhbqtz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable +1 for including checkstyl to "Build Apache Ignite". =D0=92 =D0=A1=D1=80, 12/06/2019 =D0=B2 21:29 +0300, =D0=9F=D0=B0=D0=B2=D0= =BB=D1=83=D1=85=D0=B8=D0=BD =D0=98=D0=B2=D0=B0=D0=BD =D0=BF=D0=B8=D1=88=D0= =B5=D1=82: > Maxim, >=20 > Options 1 and 3 sounds fine to me. And taking into account current > state I tend to think that option 1 is even better. >=20 > =D0=B2=D1=82, 11 =D0=B8=D1=8E=D0=BD. 2019 =D0=B3. =D0=B2 14:19, Maxim Muz= afarov : > >=20 > > Dmitry, > >=20 > > Thank you. > > Sure, I'll not change anything on TC without discussion with all the co= mmunity. > >=20 > > On Tue, 11 Jun 2019 at 13:30, Dmitriy Pavlov wrote= : > > >=20 > > > Hi Maxim, > > >=20 > > > I've granted role Ignite Tests Admins to your account. Please check. > > >=20 > > > Please notify community on any significant changes you do. Unfortunat= ely, > > > TC parameters audit is not so convenient as VCS-based configuration/c= ode. > > >=20 > > > Sincerely > > > Dmitriy Pavlov > > >=20 > > > =D0=BF=D0=BD, 10 =D0=B8=D1=8E=D0=BD. 2019 =D0=B3. =D0=B2 17:03, Maxim= Muzafarov : > > >=20 > > > > Igniters, > > > >=20 > > > > It seems to me that building [ignite-scalar] module under JDK9+ hav= e > > > > been successfully solved for the ~Build Apache Ignite~ suite [1] [2= ] > > > > [3], but it was not configured for the [Check Code Style] suite. We > > > > should configure it the same way (but it sounds to me very odd). I > > > > see, that we have several options here: > > > >=20 > > > > 1. Enable `checkstyle` profile for the ~Build Apache Ignite~ suite = as > > > > we've discussed it previously [4] and forget about any duplicate > > > > configuration once and for all. One more thing to do so is that che= ck > > > > style has been violated for a few days and nobody mentioned it [5]. > > > >=20 > > > > 2. Since the checkstyle plugin is not related to scala-source code = (it > > > > does not check it) we can exclude scala modules from maven build > > > > procedure for the checkstyle suite by adding some command-line > > > > parameters (test them locally, but have no TC permissions to check = it > > > > on TC): > > > > -pl > > > > -:ignite-scalar_2.10,-:ignite-scalar,-:ignite-visor-console,-:ignit= e-visor-console_2.10 > > > >=20 > > > > 3. Configure [Check Code Style] the same way as ~Build Apache Ignit= e~ > > > > to support builds for JDK9+. > > > >=20 > > > > WDYT? > > > > What options will be the best for the Apache Ignite? > > > >=20 > > > > [1] https://github.com/scala/bug/issues/10871 > > > > [2] https://issues.apache.org/jira/browse/IGNITE-6730 > > > > [3] https://issues.apache.org/jira/browse/IGNITE-11189 > > > > [4] > > > > http://apache-ignite-developers.2346864.n4.nabble.com/Code-inspecti= on-tp27709p41297.html > > > > [5] https://issues.apache.org/jira/browse/IGNITE-11899 > > > >=20 > > > > On Fri, 7 Jun 2019 at 15:36, Nikolay Izhikov = wrote: > > > > >=20 > > > > > Hello, Petr. > > > > >=20 > > > > > > at least Scala does not compile > > > > >=20 > > > > > How cat I reproduce it? > > > > > Do we have ticket? > > > > >=20 > > > > > =D0=92 =D0=9F=D1=82, 07/06/2019 =D0=B2 15:28 +0300, Petr Ivanov = =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > > > > > Suite fails because Apache Ignite compilation is not supported = under > > > >=20 > > > > JDK 9+ (at least Scala does not compile). > > > > > > Your build from [3] was triggered with JDK 11. > > > > > >=20 > > > > > > > On 7 Jun 2019, at 14:57, Maxim Muzafarov = wrote: > > > > > > >=20 > > > > > > > Igniters, > > > > > > >=20 > > > > > > > I've noticed a few problems with Code Style Check Suite on TC= in the > > > > > > > master branch. > > > > > > >=20 > > > > > > > 1. Some of the rules have been violated by previous commits t= o the > > > > > > > master branch. I've created ticket [1] and have prepared PR [= 2] which > > > > > > > is fixing it. > > > > > > > Dmitry, or maybe someone else, can you take a look, please? > > > > > > >=20 > > > > > > > 2. The Code Style Check Stuite still fails (time to time) on = TC with > > > > > > > compile error on [ignite-scalar] module > > > > > > > (java.lang.NoClassDefFoundError: javax/tools/ToolProvider). F= or > > > > > > > instance, this build [3] fails and this is fully ok [4]. Howe= ver, the > > > > > > > ~Build Apache Ignite~ Suite with almost the same configuratio= n passes > > > > > > > normally. > > > > > > >=20 > > > > > > > I'd like to create a new suite with checkstyle for debug purp= oses, > > > >=20 > > > > can > > > > > > > anyone grant permission to copy\clone\edit suites on TC? My l= ogin: > > > > > > > maxmuzaf@gmail.com > > > > > > >=20 > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-11899 > > > > > > > [2] https://github.com/apache/ignite/pull/6597 > > > > > > > [3] > > > >=20 > > > > https://ci.ignite.apache.org/viewLog.html?buildId=3D4020653&buildTy= peId=3DIgniteTests24Java8_CheckCodeStyle&tab=3DbuildLog&branch_IgniteTests2= 4Java8=3D%3Cdefault%3E > > > > > > > [4] > > > >=20 > > > > https://ci.ignite.apache.org/viewLog.html?buildId=3D4021372&buildTy= peId=3DIgniteTests24Java8_CheckCodeStyle > > > > > >=20 > > > > > >=20 >=20 >=20 >=20 --=-OrfOd0I4LxmEDrqhbqtz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEOiTcLcdgyP2exB5ZbiaPbjg91GUFAl0BSlwACgkQbiaPbjg9 1GXixQf9GgFR2TjVaaBubioc5RLdh0CHz0GZMCioPcKnXxEDtELjks18cCSeINr1 qyybtLTBjwRfqMnzwKLKxfPuVEOliOxfGk6/eJlVWRokFPqDC9spTyHf053D56pV 7BF1VI/OxHBA6apN9aU/RJJTA7rA0eE21nfKCKI9InJG64mpT6Lx2LtVONXW663j T5ujnDAPX/eSkjJt0IR0b2Yi1sG86Nn829O6bDADIMPYcsILZqo6r86eHoDYs+CM MP0ndZV0Daay0JumWmS+XXiSq/H0pfg+EaWcHi81XbKvieee6Cjs5XCPWE3FASwz YJEJ+4rLMjgR5FXtRNPm/wgjRTz+FQ== =Z0oj -----END PGP SIGNATURE----- --=-OrfOd0I4LxmEDrqhbqtz--