From adffaces-dev-return-1334-apmail-incubator-adffaces-dev-archive=incubator.apache.org@incubator.apache.org Fri Oct 06 16:36:22 2006 Return-Path: Delivered-To: apmail-incubator-adffaces-dev-archive@locus.apache.org Received: (qmail 85143 invoked from network); 6 Oct 2006 16:36:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 6 Oct 2006 16:36:22 -0000 Received: (qmail 73352 invoked by uid 500); 6 Oct 2006 16:36:21 -0000 Delivered-To: apmail-incubator-adffaces-dev-archive@incubator.apache.org Received: (qmail 73329 invoked by uid 500); 6 Oct 2006 16:36:21 -0000 Mailing-List: contact adffaces-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: adffaces-dev@incubator.apache.org Delivered-To: mailing list adffaces-dev@incubator.apache.org Received: (qmail 73320 invoked by uid 99); 6 Oct 2006 16:36:21 -0000 Received: from idunn.apache.osuosl.org (HELO idunn.apache.osuosl.org) (140.211.166.84) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Oct 2006 09:36:21 -0700 Authentication-Results: idunn.apache.osuosl.org header.from=awiner@gmail.com; domainkeys=good X-ASF-Spam-Status: No, hits=0.5 required=5.0 tests=DNS_FROM_RFC_ABUSE DomainKey-Status: good X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 Received: from [66.249.92.168] ([66.249.92.168:27389] helo=ug-out-1314.google.com) by idunn.apache.osuosl.org (ecelerity 2.1.1.8 r(12930)) with ESMTP id 5C/B5-24193-00686254 for ; Fri, 06 Oct 2006 09:36:18 -0700 Received: by ug-out-1314.google.com with SMTP id y2so452805uge for ; Fri, 06 Oct 2006 09:36:14 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=NGlHCUxsFVSDm3Tq7QEdnaOdoAH92XjqVCMETUNJwaWRP4vPSwyu95rQTdCqTxC4FLeMDG5TjiuslwJV8Jop3t89x52hn1qDWBd+Ex7CaLgrGvZrEKrWLhhEwYmQObBzngWnGUNoutcL+Lt7q7PSrh3Eq0AbCsnjKScfIlZujH0= Received: by 10.66.240.12 with SMTP id n12mr3417082ugh; Fri, 06 Oct 2006 09:36:13 -0700 (PDT) Received: by 10.67.102.2 with HTTP; Fri, 6 Oct 2006 09:36:13 -0700 (PDT) Message-ID: <6dac79b90610060936v107b7e71tf1a88346089cbb00@mail.gmail.com> Date: Fri, 6 Oct 2006 09:36:13 -0700 From: "Adam Winer" To: adffaces-dev@incubator.apache.org, Martin.Koci@aura.cz Subject: ADFFACES-214: EditableValueRenderer does not handle EvaluationException in method getReadOnly MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Martin, Looking at this bug and patch, I'm not sure of the right way to go. I'm worried about this; if the exception is thrown constantly, that could be a significant performance problem. I'm not at all sure that we wouldn't want to warn the developer (hence, _LOG.warning()). Also, maybe returning true would be better than false here, since the value isn't writable. If we do catch the exception, what happens later when the value is actually retrieved for rendering? Isn't that just going to generate another uncaught exception? -- Adam