incubator-adffaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arjuna Wijeyekoon" <arj...@gmail.com>
Subject Base64OutputStream needs a cleanup
Date Thu, 09 Nov 2006 03:07:35 GMT
The public class:
org.apache.myfaces.trinidad.util.Base64OutputStream

is annoying me.

1. it has a finish() method instead of a close() method.
2. it doesn't have a close() method at all. It should have one that
delegates to the
underlying Writer
3. it doesn't have a flush() method that delegates to the underlying writer.

I think we should fix these issues before we have a public release.
is it ok if I file a JIRA?

--arjuna

Mime
View raw message