incubator-adffaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arjuna Wijeyekoon" <arj...@gmail.com>
Subject Re: Base64OutputStream needs a cleanup
Date Thu, 09 Nov 2006 18:58:40 GMT
thanks guys.
http://issues.apache.org/jira/browse/ADFFACES-283

On 11/8/06, Simon Lessard <simon.lessard.3@gmail.com> wrote:
> Yeah that would be a good idea.
>
> On 11/9/06, Adam Winer <awiner@gmail.com> wrote:
> >
> > I agree, it'd be good to fix all those.
> >
> > -- Adam
> >
> >
> > On 11/8/06, Arjuna Wijeyekoon <arjuna@gmail.com> wrote:
> > > The public class:
> > > org.apache.myfaces.trinidad.util.Base64OutputStream
> > >
> > > is annoying me.
> > >
> > > 1. it has a finish() method instead of a close() method.
> > > 2. it doesn't have a close() method at all. It should have one that
> > > delegates to the
> > > underlying Writer
> > > 3. it doesn't have a flush() method that delegates to the underlying
> > writer.
> > >
> > > I think we should fix these issues before we have a public release.
> > > is it ok if I file a JIRA?
> > >
> > > --arjuna
> > >
> >
>
>

Mime
View raw message