incubator-adffaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jijun Wang <jijun.w...@oracle.com>
Subject Re: Next steps? (was Re: Is trinidad ready for graduation ?)
Date Tue, 10 Apr 2007 19:08:07 GMT

In trinidad, we have some code snippet that uses exception as part of 
message string instead of a throwable parameter.
For example in 
incubator\trinidad\trunk\trinidad\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\context\external\ServletExternalContext.java

public class ServletExternalContext extends ExternalContext
{
public ServletExternalContext(final ServletContext servletContext,
      final ServletRequest servletRequest, final ServletResponse 
servletResponse)
  {
...
 catch (final Exception e)
      {
        if (_LOG.isWarning())
        {
          _LOG.warning("Failed to set character encoding " + e);
        }
      }
    }
  }

Should it actually be _LOG.warning("Failed to set character encoding ", 
e); ?

Jijun Wang



Mime
View raw message