incubator-droids-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thorsten Scherler (JIRA)" <j...@apache.org>
Subject [jira] Closed: (DROIDS-49) Make LinkTask.started non-final, and rename it propertly
Date Wed, 06 May 2009 21:35:30 GMT

     [ https://issues.apache.org/jira/browse/DROIDS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Thorsten Scherler closed DROIDS-49.
-----------------------------------

    Resolution: Fixed

Committed revision 772434.

Thanks Mingfai

> Make LinkTask.started non-final, and rename it propertly
> --------------------------------------------------------
>
>                 Key: DROIDS-49
>                 URL: https://issues.apache.org/jira/browse/DROIDS-49
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>            Reporter: Mingfai Ma
>            Assignee: Thorsten Scherler
>         Attachments: DROIDS-49.patch
>
>
> started/taskDate should be final, but it caused a problem to me in doing unit test that
a huge number of LinkTask are to be created with different started date
> my suggestion:
> 1. make started non-final
> 2. add a constructor 
> by design, the 2nd one is better. but in terms of maintainability, it's better not to
add too many constructors. 
> The HttpCore design has some examples (http header of response?! sth like that) that
final attributes are not necessarily be made as final/immune. I suggest just to make the started
field non-final.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message