incubator-droids-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugen Paraschiv (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DROIDS-125) SaveHandler - clean up
Date Sun, 20 Feb 2011 15:32:38 GMT

     [ https://issues.apache.org/jira/browse/DROIDS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Eugen Paraschiv updated DROIDS-125:
-----------------------------------

    Attachment: DROIDS-125_v1.patch

The patch addresses the points described in the issue and should not introduce any logic change
in the code. 

> SaveHandler - clean up
> ----------------------
>
>                 Key: DROIDS-125
>                 URL: https://issues.apache.org/jira/browse/DROIDS-125
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.0.1
>            Reporter: Eugen Paraschiv
>             Fix For: 0.0.1
>
>         Attachments: DROIDS-125_v1.patch
>
>
> There are a few things that should be cleaned up in SaveHandler: 
> - should remove the default values for class members (unnecessary)
> - should remove the caught and rethrown IOException (unnecessary)
> - should separate the responsibility of calculating the file path from the actual writing
of the output
> - could inject the outputDir the constructor

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message