incubator-droids-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugen Paraschiv (JIRA)" <j...@apache.org>
Subject [jira] Created: (DROIDS-125) SaveHandler - clean up
Date Sun, 20 Feb 2011 12:26:38 GMT
SaveHandler - clean up
----------------------

                 Key: DROIDS-125
                 URL: https://issues.apache.org/jira/browse/DROIDS-125
             Project: Droids
          Issue Type: Improvement
          Components: core
    Affects Versions: 0.0.1
            Reporter: Eugen Paraschiv
             Fix For: 0.0.1


There are a few things that should be cleaned up in SaveHandler: 
- default values for class members are unnecessary
- IOException caught and rethrown unnecessary
- separate the responsibility of calculating the file path from the actual writing of the
output
- the outputDir should be injected in the constructor, because it is not optional - it has
to be present so that the handler can function

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message