incubator-droids-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bertil Chapuis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DROIDS-113) RegexURLFilter uses find() instead of matches() to match the regex
Date Wed, 16 Feb 2011 12:44:57 GMT

    [ https://issues.apache.org/jira/browse/DROIDS-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995273#comment-12995273
] 

Bertil Chapuis commented on DROIDS-113:
---------------------------------------

The tests are not failing anymore. I applied the patch so you can close the issue. Thanks
a lot for your work.

> RegexURLFilter uses find() instead of matches() to match the regex
> ------------------------------------------------------------------
>
>                 Key: DROIDS-113
>                 URL: https://issues.apache.org/jira/browse/DROIDS-113
>             Project: Droids
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.0.1
>            Reporter: Eugen Paraschiv
>             Fix For: 0.0.1
>
>         Attachments: DROIDS-113_v1.patch, DROIDS-113_v2.patch
>
>
> By matching the regex via find() and not matches(), the client doesn't have full control
over the url matching process, because the regex is not used to match the entire url but any
part of it, which may not be correct. 
> If the client wants to allow flexibility in the URL structure, he can do so with the
regex expression itself, but the actual matching process should try to match the entire url,
not just parts of it. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message