incubator-droids-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Otis Gospodnetic (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DROIDS-123) Better formatting consistency for the Droids codebase
Date Fri, 18 Mar 2011 19:36:29 GMT

    [ https://issues.apache.org/jira/browse/DROIDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008594#comment-13008594
] 

Otis Gospodnetic commented on DROIDS-123:
-----------------------------------------

+1.  Massive cosmetic patches will break pretty much all existing patches, unless those patches
are applied with:

       -l  or  --ignore-whitespace
          Match  patterns loosely, in case tabs or spaces have been munged in your files.
 Any sequence of one or more blanks in the patch file matches any sequence in the original
file, and sequences of blanks at the ends of lines
          are ignored.  Normal characters must still match exactly.  Each line of the context
must still match a line in the original file.

But I think even then things will break if cosmetic changes go beyond simple spacing changes.


> Better formatting consistency for the Droids codebase 
> ------------------------------------------------------
>
>                 Key: DROIDS-123
>                 URL: https://issues.apache.org/jira/browse/DROIDS-123
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.0.2
>            Reporter: Eugen Paraschiv
>             Fix For: 0.0.2
>
>         Attachments: DROIDS-123-introducing-jalopy.patch, DROIDS-123_step1_v1.patch,
DROIDS-123_step2_v1.patch, eclipse-java-profile.xml
>
>
> The formatting in droids should effectively be the same as the standard Java Conventions
build in Eclipse formatter. However, the are multiple formatting inconsistencies in the droids
codebas. 
> Examples: 
> 1. braces
> - SimpleTaskQueue - even in the same class, there are cases where the opening braces
are on the same line as the method signature: 
> public T next() {
> and cases where they are not: 
> public void clear()
>   {
> 2. whitespace 
> - sometimes there is a whitespace between a 'for' and the '('
> for (
> and sometimes there is not: 
> for(
> The proposal to deal with this is to start with the Java build in formatter in Eclipse
(with a few minor changes), and format the entire droids codebase - the changes should be
minor in most cases. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message