From droids-dev-return-1187-apmail-incubator-droids-dev-archive=incubator.apache.org@incubator.apache.org Wed Mar 16 12:14:54 2011 Return-Path: Delivered-To: apmail-incubator-droids-dev-archive@minotaur.apache.org Received: (qmail 5831 invoked from network); 16 Mar 2011 12:14:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 16 Mar 2011 12:14:53 -0000 Received: (qmail 88589 invoked by uid 500); 16 Mar 2011 12:14:53 -0000 Delivered-To: apmail-incubator-droids-dev-archive@incubator.apache.org Received: (qmail 88567 invoked by uid 500); 16 Mar 2011 12:14:53 -0000 Mailing-List: contact droids-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: droids-dev@incubator.apache.org Delivered-To: mailing list droids-dev@incubator.apache.org Received: (qmail 88559 invoked by uid 99); 16 Mar 2011 12:14:53 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Mar 2011 12:14:53 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Mar 2011 12:14:51 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 8BC3E3AC8E2 for ; Wed, 16 Mar 2011 12:14:29 +0000 (UTC) Date: Wed, 16 Mar 2011 12:14:29 +0000 (UTC) From: "Bertil Chapuis (JIRA)" To: droids-dev@incubator.apache.org Message-ID: <632925627.6360.1300277669569.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1482196463.18911.1297807077485.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] Updated: (DROIDS-123) Better formatting consistency for the Droids codebase MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DROIDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertil Chapuis updated DROIDS-123: ---------------------------------- Attachment: DROIDS-123-introducing-jalopy.patch I just had a look at how log4j is using jalopy to specify coding guidelines and format its code. The following patch is compatible with the current Droids coding convention and the results with mvn jalopy:format are quite good. > Better formatting consistency for the Droids codebase > ------------------------------------------------------ > > Key: DROIDS-123 > URL: https://issues.apache.org/jira/browse/DROIDS-123 > Project: Droids > Issue Type: Improvement > Components: core > Affects Versions: 0.0.2 > Reporter: Eugen Paraschiv > Fix For: 0.0.2 > > Attachments: DROIDS-123-introducing-jalopy.patch, DROIDS-123_step1_v1.patch, DROIDS-123_step2_v1.patch > > > The formatting in droids should effectively be the same as the standard Java Conventions build in Eclipse formatter. However, the are multiple formatting inconsistencies in the droids codebas. > Examples: > 1. braces > - SimpleTaskQueue - even in the same class, there are cases where the opening braces are on the same line as the method signature: > public T next() { > and cases where they are not: > public void clear() > { > 2. whitespace > - sometimes there is a whitespace between a 'for' and the '(' > for ( > and sometimes there is not: > for( > The proposal to deal with this is to start with the Java build in formatter in Eclipse (with a few minor changes), and format the entire droids codebase - the changes should be minor in most cases. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira