incubator-droids-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tony Dietrich (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DROIDS-150) Inputstream not close after file read when loading regex filters in RegexURLFilter class
Date Wed, 26 Oct 2011 08:59:32 GMT

    [ https://issues.apache.org/jira/browse/DROIDS-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135817#comment-13135817
] 

Tony Dietrich commented on DROIDS-150:
--------------------------------------

I acept that there's a default of 10 in ArrayList, but the specs for java 7 onwards are moving
towards explicit initialisation .. I think we should start the habit now to future proof the
code.

I've been using java 7 for a while now .. its stable enough, and the memory management is
a huge improvement .. I'm seeing apps running at 50-60% of their previous memory demands.
Add in coding improvements like the try-with-resources and diamond operators, it makes coding
a hell of a lot easier.

Incidentally, Apache Droids runs as-is quite happily under java 7 .. I've updated the pom
to source 1.7 and it compiles and runs sweetly.  I'm not pushing for it to be adopted by everyone
else, since not everyone will want to update their systems... and anyway, not everyone will
want to re-compile the library sources. Again, memory usage is a lot better for Droids under
java 7.
                
> Inputstream not close after file read when loading regex filters in RegexURLFilter class
> ----------------------------------------------------------------------------------------
>
>                 Key: DROIDS-150
>                 URL: https://issues.apache.org/jira/browse/DROIDS-150
>             Project: Droids
>          Issue Type: Bug
>          Components: core
>    Affects Versions: Graduating from the Incubator
>         Environment: All
>            Reporter: Tony Dietrich
>            Priority: Minor
>              Labels: fix, patch
>             Fix For: Graduating from the Incubator
>
>         Attachments: RegexYRLFilter_diff.patch
>
>
> Inputstream not closed from RegexURLFilter after loading from classpath or disk file
> Patch attached

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message