incubator-droids-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Javier Puerto (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DROIDS-150) Inputstream not close after file read when loading regex filters in RegexURLFilter class
Date Wed, 26 Oct 2011 08:47:32 GMT

    [ https://issues.apache.org/jira/browse/DROIDS-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135811#comment-13135811
] 

Javier Puerto commented on DROIDS-150:
--------------------------------------

IMO this is true if you want to create an array for something concrete and you know the size
or you know how it can grow. In ArrayList source code the size is set to 10 by default, that's
why I don't understand why we initialized the size to 16. I think we should leave it as default
to avoid confusion. WDYT?

I didn't know the new Java 7 feature, looks very interesting. I think that at the moment Java
7 is too new so we should keep the java 1.6 compatibility.

The finally block is only to be sure that the stream is closed also as the method explicity
declares a IOException, I don't think that we need to catch and re-throw.


                
> Inputstream not close after file read when loading regex filters in RegexURLFilter class
> ----------------------------------------------------------------------------------------
>
>                 Key: DROIDS-150
>                 URL: https://issues.apache.org/jira/browse/DROIDS-150
>             Project: Droids
>          Issue Type: Bug
>          Components: core
>    Affects Versions: Graduating from the Incubator
>         Environment: All
>            Reporter: Tony Dietrich
>            Priority: Minor
>              Labels: fix, patch
>             Fix For: Graduating from the Incubator
>
>         Attachments: RegexYRLFilter_diff.patch
>
>
> Inputstream not closed from RegexURLFilter after loading from classpath or disk file
> Patch attached

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message