incubator-droids-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard Frovarp (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DROIDS-163) SimpleTaskQueueWithHistory addAll does not add the new tasks
Date Mon, 05 Dec 2011 17:54:39 GMT

    [ https://issues.apache.org/jira/browse/DROIDS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162902#comment-13162902
] 

Richard Frovarp commented on DROIDS-163:
----------------------------------------

It took me a couple of minutes to realize why the existing code doesn't work and why your
patch would. Would it perhaps make sense to leave the short circuiting or in there, but call
this.add(e) first? Would that be more clear?
                
> SimpleTaskQueueWithHistory addAll does not add the new tasks 
> -------------------------------------------------------------
>
>                 Key: DROIDS-163
>                 URL: https://issues.apache.org/jira/browse/DROIDS-163
>             Project: Droids
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.0.2
>            Reporter: Tobias Rübner
>             Fix For: 0.0.2
>
>         Attachments: DROIDS-163.patch
>
>
> The method addAll should add a list of new Tasks to the queue.
> It must be looked to already added tasks to prevent double parsing of files.
> But the method always returned false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message