incubator-s4-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mmo...@apache.org
Subject [18/50] [abbrv] git commit: Cleaned up some left-over comments in NettyEmitter
Date Tue, 03 Jan 2012 14:03:28 GMT
Cleaned up some left-over comments in NettyEmitter


Project: http://git-wip-us.apache.org/repos/asf/incubator-s4/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-s4/commit/edaa3468
Tree: http://git-wip-us.apache.org/repos/asf/incubator-s4/tree/edaa3468
Diff: http://git-wip-us.apache.org/repos/asf/incubator-s4/diff/edaa3468

Branch: refs/heads/piper
Commit: edaa3468d5d69ad6d6e72deddd538e266b6c9474
Parents: 2f8051f
Author: Karthik Kambatla <kkambatl@cs.purdue.edu>
Authored: Mon Nov 28 01:28:33 2011 -0500
Committer: Karthik Kambatla <kkambatl@cs.purdue.edu>
Committed: Mon Nov 28 01:28:33 2011 -0500

----------------------------------------------------------------------
 .../org/apache/s4/comm/netty/NettyEmitter.java     |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-s4/blob/edaa3468/subprojects/s4-comm/src/main/java/org/apache/s4/comm/netty/NettyEmitter.java
----------------------------------------------------------------------
diff --git a/subprojects/s4-comm/src/main/java/org/apache/s4/comm/netty/NettyEmitter.java
b/subprojects/s4-comm/src/main/java/org/apache/s4/comm/netty/NettyEmitter.java
index 3d95ef2..15ff77d 100644
--- a/subprojects/s4-comm/src/main/java/org/apache/s4/comm/netty/NettyEmitter.java
+++ b/subprojects/s4-comm/src/main/java/org/apache/s4/comm/netty/NettyEmitter.java
@@ -93,8 +93,6 @@ public class NettyEmitter implements Emitter, ChannelFutureListener, TopologyCha
     private HashBiMap<Integer, ClusterNode> partitionNodeMap;
     private MessageQueuesPerPartition queuedMessages = new MessageQueuesPerPartition(true);
 
-    // private MessageQueuesPerPartition messagesOnTheWire = new MessageQueuesPerPartition(false);
-
     @Inject
     public NettyEmitter(Topology topology) throws InterruptedException {
         this.topology = topology;
@@ -156,9 +154,6 @@ public class NettyEmitter implements Emitter, ChannelFutureListener, TopologyCha
     }
 
     private void writeMessageToChannel(Channel channel, int partitionId, byte[] message)
{
-        // if (addToWire) {
-        // messagesOnTheWire.add(partitionId, message);
-        // }
         ChannelBuffer buffer = ChannelBuffers.buffer(message.length);
         buffer.writeBytes(message);
         ChannelFuture f = channel.write(buffer);
@@ -272,7 +267,6 @@ public class NettyEmitter implements Emitter, ChannelFutureListener, TopologyCha
             Integer partitionId = partitionChannelMap.inverse().get(context.getChannel());
             if (partitionId == null) {
                 logger.error("Error on mystery channel!!");
-                // return;
             }
             logger.error("Error on channel to partition " + partitionId);
 


Mime
View raw message