incubator-stonehenge-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Dewey <Ben.De...@26ny.com>
Subject RE: [jira] Commented: (STONEHENGE-81) Code Cleanup for the ConfigService
Date Mon, 13 Jul 2009 21:27:53 GMT
+1 frankly if the UI is managing the selection of endpoints I could care less what there named
(within reason of course)

-Ben

-----Original Message-----
From: Avantika Agrawal (JIRA) [mailto:jira@apache.org] 
Sent: Monday, July 13, 2009 2:03 PM
To: stonehenge-dev@incubator.apache.org
Subject: [jira] Commented: (STONEHENGE-81) Code Cleanup for the ConfigService


    [ https://issues.apache.org/jira/browse/STONEHENGE-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730432#action_12730432
] 

Avantika Agrawal commented on STONEHENGE-81:
--------------------------------------------

I am looking for ways to simplify the process of adding new endpoints and it seems like we're
doing a lot of repeated mappings of the endpointConfigStrings from the App.config to the Settings
class and within the switch statements in the code. 

I am thinking of eliminating all these switch statements and mappings by firstly switching
the labels in the App.config to match those in the database and then calling:
new Client.Client(typeof(ITradeServices), ConfigurationManager.AppSettings.Get(GetClientConfig("DOTNET_CLIENT"))

This sort of circumvents the process of calling the Settings class to get all the endpoints
from the app.config. Any thoughts?

> Code Cleanup for the ConfigService
> ----------------------------------
>
>                 Key: STONEHENGE-81
>                 URL: https://issues.apache.org/jira/browse/STONEHENGE-81
>             Project: Stonehenge
>          Issue Type: Improvement
>            Reporter: Avantika Agrawal
>            Priority: Trivial
>
> There is some unused code in Utility.cs, Settings.cs and the config files of .NET StockTrader.
This should be removed. In addition -we should try to refactor the code to simplify the process
of adding new endpoints - by eliminating some switch statements, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Mime
View raw message