From commits-return-21715-apmail-jackrabbit-commits-archive=jackrabbit.apache.org@jackrabbit.apache.org Tue Jul 23 15:44:47 2019 Return-Path: X-Original-To: apmail-jackrabbit-commits-archive@www.apache.org Delivered-To: apmail-jackrabbit-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id BBA17181D8 for ; Tue, 23 Jul 2019 15:44:46 +0000 (UTC) Received: (qmail 67736 invoked by uid 500); 23 Jul 2019 15:44:46 -0000 Delivered-To: apmail-jackrabbit-commits-archive@jackrabbit.apache.org Received: (qmail 67700 invoked by uid 500); 23 Jul 2019 15:44:46 -0000 Mailing-List: contact commits-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list commits@jackrabbit.apache.org Received: (qmail 67691 invoked by uid 99); 23 Jul 2019 15:44:46 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jul 2019 15:44:46 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 6F2403A387B for ; Tue, 23 Jul 2019 15:44:45 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1863646 - /jackrabbit/commons/filevault-package-maven-plugin/trunk/src/test/java/org/apache/jackrabbit/filevault/maven/packaging/it/ProjectBuilder.java Date: Tue, 23 Jul 2019 15:44:45 -0000 To: commits@jackrabbit.apache.org From: kwin@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20190723154445.6F2403A387B@svn01-us-west.apache.org> Author: kwin Date: Tue Jul 23 15:44:45 2019 New Revision: 1863646 URL: http://svn.apache.org/viewvc?rev=1863646&view=rev Log: JCRVLT-342 close pom.xml correctly after retrieving version Modified: jackrabbit/commons/filevault-package-maven-plugin/trunk/src/test/java/org/apache/jackrabbit/filevault/maven/packaging/it/ProjectBuilder.java Modified: jackrabbit/commons/filevault-package-maven-plugin/trunk/src/test/java/org/apache/jackrabbit/filevault/maven/packaging/it/ProjectBuilder.java URL: http://svn.apache.org/viewvc/jackrabbit/commons/filevault-package-maven-plugin/trunk/src/test/java/org/apache/jackrabbit/filevault/maven/packaging/it/ProjectBuilder.java?rev=1863646&r1=1863645&r2=1863646&view=diff ============================================================================== --- jackrabbit/commons/filevault-package-maven-plugin/trunk/src/test/java/org/apache/jackrabbit/filevault/maven/packaging/it/ProjectBuilder.java (original) +++ jackrabbit/commons/filevault-package-maven-plugin/trunk/src/test/java/org/apache/jackrabbit/filevault/maven/packaging/it/ProjectBuilder.java Tue Jul 23 15:44:45 2019 @@ -123,10 +123,10 @@ public class ProjectBuilder { private String getPluginVersion() { String pluginVersion = System.getProperty("plugin.version"); if (pluginVersion == null) { - try { + try (FileReader fileReader = new FileReader("pom.xml")) { // try to read from project MavenXpp3Reader reader = new MavenXpp3Reader(); - Model model = reader.read(new FileReader("pom.xml")); + Model model = reader.read(fileReader); pluginVersion = model.getVersion(); } catch (IOException | XmlPullParserException e) { log.error("Unable to read version from pom", e);