jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-464) RootImpl.rebase() doesn't handle move operations correctly
Date Mon, 03 Dec 2012 13:07:59 GMT

    [ https://issues.apache.org/jira/browse/OAK-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508704#comment-13508704
] 

Thomas Mueller commented on OAK-464:
------------------------------------

About:

{code}
public String rebase(String branchRevision, String newBaseRevision) {
    String revision = branch(newBaseRevision);
    for (String jsop : getBranchCommitsUntil(branchRevision)) {
        revision = commit("/", jsop, revision, null);
    }
    return revision;
}
{code}

It seems the only reason this can not currently be implemented on top of the MicroKernel API
is because getJournal is specified to not work for branch commits. If getJournal can return
branch commits, then I don't see a reason why this couldn't be implemented on top of oak-core.

So, if this is really the only missing piece, I would rather support branch commits in getJournal,
and then implement the feature above in oak-core.

                
> RootImpl.rebase() doesn't handle move operations correctly
> ----------------------------------------------------------
>
>                 Key: OAK-464
>                 URL: https://issues.apache.org/jira/browse/OAK-464
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>            Reporter: Michael Dürig
>
> Doing {{RootImpl.rebase()}} causes moves to be changed to remove followed by add. Which
causes moves of large sub trees to become very expensive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message