jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-464) RootImpl.rebase() doesn't handle move operations correctly
Date Mon, 03 Dec 2012 10:43:58 GMT

    [ https://issues.apache.org/jira/browse/OAK-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508638#comment-13508638
] 

Thomas Mueller commented on OAK-464:
------------------------------------

I'm wondering why "rebase operation on top of the Microkernel" need diffing between the involved
node states. Is the problem that "getBranchCommitsUntil" is not possible with the current
MicroKernel API? If yes, should we rather change the MicroKernel API to allow it (getJournal
to support reading the journal for branch commits)?

I'm just against pushing more functionality down to the MicroKernel implementation. It should
be simple to implement.

Jukka, to your code example "The implementation would be equivalent to something like this"
- the loop contains multiple commits. Is each of those commits atomic? What about conflicts?

                
> RootImpl.rebase() doesn't handle move operations correctly
> ----------------------------------------------------------
>
>                 Key: OAK-464
>                 URL: https://issues.apache.org/jira/browse/OAK-464
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>            Reporter: Michael Dürig
>
> Doing {{RootImpl.rebase()}} causes moves to be changed to remove followed by add. Which
causes moves of large sub trees to become very expensive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message