jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Commented] (OAK-1132) QueryEngine #executeQuery creates a new revision on each call
Date Fri, 08 Nov 2013 08:55:17 GMT

    [ https://issues.apache.org/jira/browse/OAK-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817122#comment-13817122

Michael Dürig commented on OAK-1132:

bq. Query execution now uses the base state for normal index lookups.

At least to me it isn't obvious why the base state is sufficient here while for the second
argument we need a {{Tree}} for the head state. Especially since the respective method names
on {{ExecutionContext}} suggest the two entities being the same except for access control
evaluation. [~jukkaz], [~alex.parvulescu] could you clarify this in the  Javadoc of {{ExecutionContext}}.

> QueryEngine #executeQuery creates a new revision on each call
> -------------------------------------------------------------
>                 Key: OAK-1132
>                 URL: https://issues.apache.org/jira/browse/OAK-1132
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: query, segmentmk
>            Reporter: Alex Parvulescu
>             Fix For: 0.11
> It looks like the #getQueryEngine relies on the node state provided by _AbstractRoot.this.getRootState()_.
> On the segmentmk it looks like each call creates a new revision [0].
> One option is to switch to the base state, but it looks like there are some tests failing.
> [0] http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentRootBuilder.java?view=markup#l46

This message was sent by Atlassian JIRA

View raw message