jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-1144) Avoid wrapping TreePermission into SecurityContext
Date Tue, 05 Nov 2013 15:25:18 GMT

    [ https://issues.apache.org/jira/browse/OAK-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813983#comment-13813983
] 

Jukka Zitting commented on OAK-1144:
------------------------------------

With the added {{getChildPermission}} method {{TreePermission}} becomes essentially equivalent
to {{SecurityContext}}, so there shouldn't be a need for the separate context object anymore.
Thus +1.

We had to include the {{equals()}} method earlier as quite a few pieces of higher-level code
were still using {{NodeState.equals()}}, which would often fall back on the default and highly
inefficient {{AbstractNodeState.equals()}} implementation. AFAICT we already addressed most
of those cases, so it might well be possible to drop the {{equals()}} implementation on both
{{TreePermission/SecurityContext}} and {{SecureNodeState}}.

> Avoid wrapping TreePermission into SecurityContext
> --------------------------------------------------
>
>                 Key: OAK-1144
>                 URL: https://issues.apache.org/jira/browse/OAK-1144
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: angela
>            Assignee: angela
>            Priority: Minor
>         Attachments: OAK-1144.patch
>
>
> as suggested on the mailing list we may want to drop the extra security context (see
http://markmail.org/message/75msw25wkicy6bdu)



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message