jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] [Created] (OAK-1284) Root.commit(String, CommitHook) : CommitHook is not part of oak-api
Date Fri, 13 Dec 2013 16:11:11 GMT
angela created OAK-1284:
---------------------------

             Summary: Root.commit(String, CommitHook) : CommitHook is not part of oak-api
                 Key: OAK-1284
                 URL: https://issues.apache.org/jira/browse/OAK-1284
             Project: Jackrabbit Oak
          Issue Type: Bug
            Reporter: angela


[~fmeschbe] had a look at the oak api and spotted the following problem:

Root#commit(String, CommitHook)

But the CommitHook interface is not part of the OAK API. we quickly searched for usages and
found that this is only used for the Item#save case in oak-jcr to assert that the set of modifications
is contained with the subtree defined by the specified target item.

IMO we should get rid of the flavour of Root#commit again and solve the Item-save issue differently.
For example we could change it to Root#commit(String, String absPath) where the absPath would
be the path of the target item...



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message