jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chetan Mehrotra (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-1554) Clarify behaviour for BlobStore api for invalid arguments
Date Wed, 26 Mar 2014 09:47:17 GMT

    [ https://issues.apache.org/jira/browse/OAK-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947736#comment-13947736
] 

Chetan Mehrotra commented on OAK-1554:
--------------------------------------

Discussed this with Thomas. BlobStore design has a feature where you can combine blocks by
combining there id and testEmptyIdentifier checks for that. This feature is currently not
part of the contract of BlobStore and is kind of implementation detail.

As it does not make sense for DataStore based BlobStore I have ignored this test in MongoDataStoreBlobStoreTest
http://svn.apache.org/r1581768

> Clarify behaviour for BlobStore api for invalid arguments
> ---------------------------------------------------------
>
>                 Key: OAK-1554
>                 URL: https://issues.apache.org/jira/browse/OAK-1554
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>            Priority: Minor
>             Fix For: 0.20
>
>
> Currently testcase in AbstractBlobStore test has following check
> {code:java}
>     @Test
>     public void testEmptyIdentifier() throws Exception {
>         byte[] data = new byte[1];
>         assertEquals(-1, store.readBlob("", 0, data, 0, 1));
>         assertEquals(0, store.getBlobLength(""));
>     }
> {code}
> This fails for DataStore based BlobStore as the blodId are invalid.
> So need to clarify the behaviour around handling of invalid blobId. Should they return
result or throw exception



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message