jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chetan Mehrotra (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (OAK-1567) Return Iterator instead of returning List in DocumentStore.query
Date Sat, 29 Mar 2014 19:32:15 GMT

     [ https://issues.apache.org/jira/browse/OAK-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Chetan Mehrotra resolved OAK-1567.

       Resolution: Won't Fix
    Fix Version/s:     (was: 1.0)

This was required for Blob GC usecase. For now at least for Blob GC this is met via Mongo
specific impl of ReferenceBlobCollectory (OAK-1643). So this is not required.

If later need is felt to support this for some other case then it can be reopened

> Return Iterator instead of returning List in DocumentStore.query
> ----------------------------------------------------------------
>                 Key: OAK-1567
>                 URL: https://issues.apache.org/jira/browse/OAK-1567
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: mongomk
>    Affects Versions: 0.18
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>             Fix For: 0.20
> Currently the DocumentStore query method returns List after performing any query against
backend. In case of Mongo the DBCursor returned [1] implements Iterable interface. And in
all usage so far the code can work perfectly fine with Iterable
> It would be better if we change the api contract to return iterator and allow lazy traversal
of the NodeDocuments. Further the pagination/batching would be handled within the Driver itself
and the code above would not have to construct there on batching.
> See [2] for details
> [1] http://api.mongodb.org/java/2.0/com/mongodb/DBCursor.html
> [2] http://markmail.org/thread/ilcqtvaziie3ycb5

This message was sent by Atlassian JIRA

View raw message