jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Parvulescu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OAK-1945) SegmentMK #merge inconsistency
Date Thu, 03 Jul 2014 20:12:36 GMT

     [ https://issues.apache.org/jira/browse/OAK-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alex Parvulescu updated OAK-1945:
---------------------------------

    Attachment: MergeTest.java.patch

attaching test case. the culprit is here [0]. I don't have a good idea for a patch yet, maybe
adding to the _fastEquals_ check another clause to compare the _before_ state to the current
head?
[~jukkaz] any ideas?


[0] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentNodeStore.java#L415

> SegmentMK #merge inconsistency
> ------------------------------
>
>                 Key: OAK-1945
>                 URL: https://issues.apache.org/jira/browse/OAK-1945
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segmentmk
>            Reporter: Alex Parvulescu
>         Attachments: MergeTest.java.patch
>
>
> The SegmentMK doesn't respect the #merge contract when there is a builder that has no
local changes passed in.
> This popped-up while I was reworking the restore parts and with the new compaction code,
the only option is to pass in a NodeState#Builder builder which is considered by the #merge
method as a noop and therefore ignored.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message