jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Updated] (OAK-2254) Observation events accessibility check should respect session refresh settings
Date Fri, 07 Nov 2014 11:40:33 GMT

     [ https://issues.apache.org/jira/browse/OAK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Dürig updated OAK-2254:
-------------------------------
    Attachment: OAK-2254-v2.patch

Attaching a slightly edited version of the patch:
* use the "correct" API in the {{ChangeProcessor}} logging.
* use {{SessionDelegate#safePerform}} to get rid of the in place exception handling. 

Apart from that the patch looks good and all tests and IT pass. 

The only thing I'm a bit concerned about is performance as the additional perform and potentially
refresh call happens for every commit on every listener. This probably adds more load onto
the session lock. However, let's fork this into a separate issue when it comes up. As many
observation listeners use admin sessions, there should be room for optimisations here as in
that case acquiring the permission provider could probably be simplified. 

> Observation events accessibility check should respect session refresh settings
> ------------------------------------------------------------------------------
>
>                 Key: OAK-2254
>                 URL: https://issues.apache.org/jira/browse/OAK-2254
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: jcr
>            Reporter: Alex Parvulescu
>              Labels: observation
>         Attachments: OAK-2254-v2.patch, OAK-2254.patch
>
>
> This is related to OAK-2000. I think the accessibility check needs to respect the session
refresh settings when acquiring the root object.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message