jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-2413) Clarify Editor.childNodeChanged()
Date Tue, 10 Mar 2015 17:35:39 GMT

    [ https://issues.apache.org/jira/browse/OAK-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355280#comment-14355280

angela commented on OAK-2413:

fixed {{PrivilegeValidator}} at revision 1665630 (including a test for both before and after
state being equal or not). [~mreutegg] thanks for spotting!

> Clarify Editor.childNodeChanged()
> ---------------------------------
>                 Key: OAK-2413
>                 URL: https://issues.apache.org/jira/browse/OAK-2413
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Marcel Reutegger
>            Assignee: angela
>            Priority: Minor
>             Fix For: 1.1.8
> The current contract for {{Editor.childNodeChanged()}} does not specify if this method
may also be called when the child node did not actually change. The method {{NodeStateDiff.childNodeChanged()}}
explicitly states that there may be such calls. Looking at the implementation connecting the
two classes, {{EditorDiff.childNodeChange()}} simply calls the editor without checking whether
the child node did in fact change.
> I think we either have to change the {{EditorDiff}} or update the contract for the Editor
and adjust implementations. E.g. right now, PrivilegeValidator (implements Editor), assumes
a call to {{childNodeChange()}} indeed means the child node changed.

This message was sent by Atlassian JIRA

View raw message