jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Resolved] (OAK-3075) Compaction Estimation should type check binary properties
Date Mon, 06 Jul 2015 15:07:04 GMT

     [ https://issues.apache.org/jira/browse/OAK-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Dürig resolved OAK-3075.
--------------------------------
       Resolution: Not A Problem
    Fix Version/s:     (was: 1.3.3)
                       (was: 1.2.3)

The current code actually correctly accounts for strings (and other values) by converting
them to binaries (which corresponds to the underlying storage format) and determining the
involved segments. Added a clarifying comment at http://svn.apache.org/r1689422

> Compaction Estimation should type check binary properties
> ---------------------------------------------------------
>
>                 Key: OAK-3075
>                 URL: https://issues.apache.org/jira/browse/OAK-3075
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core, segmentmk
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>              Labels: gc
>
> It looks like the compaction estimation mechanism doesn't currently verify the type of
the property it tries to load as binary, it will assume that the following call _property.getValue(BINARIES)_
 will return nothing if the type is not BINARY. This behavior has changed since this code
was written, the way it works now is the method will try to convert to BINARY the property's
value.
> I'm assuming OAK-3007 is a side-effects of this change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message