jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tobias Bocanegra (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-3146) ExternalLoginModuleFactory should inject SyncManager and ExternalIdentityProviderManager
Date Mon, 27 Jul 2015 16:18:05 GMT

    [ https://issues.apache.org/jira/browse/OAK-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642938#comment-14642938
] 

Tobias Bocanegra commented on OAK-3146:
---------------------------------------

+1 LGTM  (I didn't test it - just reviewed)

> ExternalLoginModuleFactory should inject SyncManager and ExternalIdentityProviderManager
> ----------------------------------------------------------------------------------------
>
>                 Key: OAK-3146
>                 URL: https://issues.apache.org/jira/browse/OAK-3146
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: security
>            Reporter: Chetan Mehrotra
>            Priority: Minor
>             Fix For: 1.2.4, 1.3.4, 1.0.18
>
>         Attachments: OAK-3146.patch
>
>
> {{ExternalLoginModule}} currently performs a lookup of {{SyncManager}} and {{ExternalIdentityProviderManager}}
in initialize call which performs service lookup using ServiceTracker. Doing a service lookup
in critical path would have adverse performance impact. 
> Instead of performing the lookup {{ExternalLoginModuleFactory}} should track the two
manager instances and pass them to {{ExternalLoginModule}}. This would ensure that expensive
operation like service lookup is not performed in critical path



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message