jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tobias Bocanegra (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-3522) DefaultSyncContext exposes internal path-utility method
Date Thu, 12 Nov 2015 19:27:11 GMT

    [ https://issues.apache.org/jira/browse/OAK-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15002713#comment-15002713
] 

Tobias Bocanegra commented on OAK-3522:
---------------------------------------

+1

thanks!

> DefaultSyncContext exposes internal path-utility method
> -------------------------------------------------------
>
>                 Key: OAK-3522
>                 URL: https://issues.apache.org/jira/browse/OAK-3522
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: auth-external
>            Reporter: angela
>            Assignee: angela
>         Attachments: OAK-3522.patch, OAK-3522_2.patch, OAK-3522_3.patch
>
>
> the {{DefaultSyncContext}} defines a public static method {{joinPaths}}, which IMHO should
not be exposed as it is unrelated to the functionality defined by the {{DefaultSyncContext}}.
> i would therefore suggest to make it private (and increase the package version to 2.0.0)...
we can then still decide to move this utility to {{PathUtils}} in oak-commons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message