jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Parvulescu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-3612) The string/template cache of the SegmentWriter should be cleared before cleanup
Date Mon, 16 Nov 2015 09:21:10 GMT

    [ https://issues.apache.org/jira/browse/OAK-3612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006379#comment-15006379
] 

Alex Parvulescu commented on OAK-3612:
--------------------------------------

right. I see what you mean now. I suggest you add the specific cleanup calls to the {{cleanup}}
method on the standby [0]
this should be easy enough without the need to change anything on the oak-core level. ie:
{code}
if (delegate instanceof FileStore) {
  try {
    delegate.getTracker().getWriter().dropCache();
    tracker.clearCache();
    ((FileStore) delegate).cleanup();
  } catch (IOException e) {
{code}




[0] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-tarmk-standby/src/main/java/org/apache/jackrabbit/oak/plugins/segment/standby/store/StandbyStore.java#L242

> The string/template cache of the SegmentWriter should be cleared before cleanup
> -------------------------------------------------------------------------------
>
>                 Key: OAK-3612
>                 URL: https://issues.apache.org/jira/browse/OAK-3612
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segmentmk
>            Reporter: Francesco Mari
>             Fix For: 1.4
>
>         Attachments: OAK-3612-01.patch
>
>
> The string/template cache of the SegmentWriter (org.apache.jackrabbit.oak.plugins.segment.SegmentWriter#records)
is not cleared before the cleanup phase. This might maintain in-memory references to segments,
thus preventing them to be cleaned up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message